[SPARK-33132][WEBUI] Make formatBytes return 0.0 B for negative input instead of NaN
#30030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
changed the title
Member
dongjoon-hyun
changed the title
formatBytes return 0.0 B for negative input instead of NaN
Member
|
+1, LGTM. Thank you for your first contribution, @akiyamaneko .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
when bytesRead metric was negative,
formatBytesinui.jsshould just return0.0 Bto avoidNaN Undefinedresult.Why are the changes needed?
Strengthen the parameter validataion to improve metric display on Summary Metrics of Spark Stage UI.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It's a small change, just manual test.